Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support for to_comment/from_comment #941

Open
RFSH opened this issue Mar 31, 2022 · 1 comment
Open

Proper support for to_comment/from_comment #941

RFSH opened this issue Mar 31, 2022 · 1 comment
Labels
annotation Anything related the annotations (adding new one or changing existing one) investigation required Requires some initial investigation

Comments

@RFSH
Copy link
Member

RFSH commented Mar 31, 2022

Currently, to_comment and from_comment are only used in the related references.

We should investigate the other places (for example, aggregate columns) that should be using this. We should also make sure from_name and to_name are used consistently everywhere.

P.S. We found this while working on the annotation for functional_assay_handbook table in RBK/GUDMAP. The comments were defined on a foreign key, and we were expecting ermrestjs/chaise to use those on an array aggregate. But ermrestjs/chaise is currently using the table's comment and now we have to define redundant comments in multiple places.

@RFSH RFSH added enhancement annotation Anything related the annotations (adding new one or changing existing one) and removed enhancement labels Apr 5, 2022
@RFSH
Copy link
Member Author

RFSH commented Apr 11, 2022

This came up before as part of #852

@RFSH RFSH added the bug label Jul 7, 2023
@RFSH RFSH added the investigation required Requires some initial investigation label Feb 7, 2024
@RFSH RFSH removed the bug label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation Anything related the annotations (adding new one or changing existing one) investigation required Requires some initial investigation
Projects
None yet
Development

No branches or pull requests

1 participant