Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Use SharedInformerFactory instead of cache.NewInformer to watch K8s resources #143

Closed
PrasadG193 opened this issue Aug 7, 2019 · 0 comments · Fixed by #146
Closed

[Refactoring] Use SharedInformerFactory instead of cache.NewInformer to watch K8s resources #143

PrasadG193 opened this issue Aug 7, 2019 · 0 comments · Fixed by #146
Assignees
@PrasadG193
Labels
enhancement New feature or request
Milestone
v0.9.0

Comments

@PrasadG193
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
We should use SharedInformerFactory which has the following advantages over cache.NewInformer:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrasadG193 PrasadG193

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Use SharedInformerFactory instead of cache.Informer PrasadG193/botkube
2 participants
@sanketsudake @PrasadG193