Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ignored namespace list gets ignored #419

Closed
bribroder opened this issue Oct 28, 2020 · 0 comments · Fixed by #437 or #449
Closed

[BUG] Ignored namespace list gets ignored #419

bribroder opened this issue Oct 28, 2020 · 0 comments · Fixed by #437 or #449
Labels
bug Something isn't working

Comments

@bribroder
Copy link

Since updating from 0.10.0 to 0.11.0, ignoring some namespaces while including "all" doesn't work--the ignore list seems to simply be ignored:

config:
  ## Resources you want to watch
  resources:
  - name: v1/pods
    namespaces:
      include:
        - all
      ignore:
        - test
    events:
      - all
    updateSetting:
      includeDiff: true
      fields:
        - spec.template.spec.containers[*].image
        - status.availableReplicas

  # Check true if you want to receive recommendations
  # about the best practices for the created resource
  recommendations: true

  # Cluster Setting to manage command execution access
  settings:
    # Set true to enable kubectl commands execution
    allowkubectl: false

    # Set true to enable commands execution from configured channel only
    restrictAccess: false

    # Set true to enable config watcher
    configwatcher: true

    # Set false to disable upgrade notification
    upgradeNotifier: true

Specifying certain namespaces to include does work, but isn't ideal

@bribroder bribroder added the bug Something isn't working label Oct 28, 2020
@mergify mergify bot closed this as completed in #437 Jan 4, 2021
mergify bot pushed a commit that referenced this issue Jan 4, 2021
##### ISSUE TYPE
 - Bug fix Pull Request

##### SUMMARY
Apparently the wrong member was used to check the resource name. I don't
know how resillient this patch is, but it works for most of the part.

<!--- Please list dependencies added with your change also -->

Fixes #419
mergify bot pushed a commit that referenced this issue Jan 20, 2021
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

##### ISSUE TYPE

 - Bug fix Pull Request


##### SUMMARY

Fix namespace checker filter issue where events with ignored namespaces were not getting skipped 

Fixes #419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant