Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JobStatusChecker filter and fix timestamp for error events #108

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Add JobStatusChecker filter and fix timestamp for error events #108

merged 2 commits into from
Jun 25, 2019

Conversation

PrasadG193
Copy link
Collaborator

SUMMARY
  • Add JobStatusChecker filter to send Job success notifications when configured to watch update events
  • Add missing TimeStamps in error events

Fixes #95 and #107

SCREENSHOTS

BotKube configuration for jobs:

    - name: jobs
      namespaces:
        - all
      events:
        - delete
        - update
        - error

  1. Job success notification
    image

  2. Job Failure notification
    image

  3. Error events
    image

@PrasadG193
Add JobStatusChecker filter to send Job success notifications
9cb6683 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Add missing TimeStamp for error events
8082751 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 force-pushed the job-status-checker branch from cf51e34 to 8082751 Compare June 25, 2019 05:33
@PrasadG193 PrasadG193 merged commit bf031a0 into kubeshop:develop Jun 25, 2019
@PrasadG193 PrasadG193 mentioned this pull request Jun 25, 2019
Closed
@Israphel
Copy link

is this still valid? I don't get a job succeeded

@Nuxij
Copy link

Nuxij commented Oct 20, 2021

I am also looking at how to do job status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees

@sanketsudake sanketsudake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include job status (succeeded/failed) with notification
4 participants
@PrasadG193 @Israphel @Nuxij @sanketsudake