Enhance Notification : short/long notification type

[codenio]

ISSUE TYPE

• Feature Pull Request

SUMMARY

This commit, (updated)

• enables sending short/long event notifications to channels
• adds an optional filed "notiftype" under channel config to change between short (default) and long notif types
• adds Message() method to event object for creating brief messages (to use across handlers)
• BugFix: enable/disable recommendations through the config file

Fixes #58

Preview

[PrasadG193]

Hi @aananthraj,
Thanks for the PR. This looks awesome! Just a minor comment on the message format, can we also highlight cluster name in the notification?

[codenio]

yes, lets highlight that as well. Removing the artical A as well.
Do share if further improvements are required.

@PrasadG193, thanks for the prompt response 👍

[codenio]

any more suggestions..?

[PrasadG193]

@aananthraj, we need to add configuration related documentation in config files - helm/botkube/values.yaml, deploy-all-in-one*.yaml and ./config.yaml. Otherwise, there is no way for the user to know about this feature.
Also, I think instead of brief, we should set notiftype: long/short. We should set notiftype: short as a default value across all the config files, and if the user wants, they can switch to notiftype: long.

Let me know what you think.

[codenio]

Otherwise, there is no way for the user to know about this feature.

Yes @PrasadG193 , was thinking about updating docs as well. Will do it.

we should set notiftype: long/short. We should set notiftype: short as a default value across all the config files,

Sounds good, will make the required changes and update here.

[PrasadG193]

@aananthraj, Are we not adding Recommendations in the notifications when configured with short type? We should add it. Otherwise, it will defeat the purpose of having filters

[codenio]

@PrasadG193, doing so there would be no significance between both short/long notif types. Long type will not be used at all (as we have all infos in a short way) which questions the existance of Long NotifType. Is this ok..?

[PrasadG193]

@aananthraj with short notification type, we do optimize a lot of space by combining name, kind, namespace and clustername into a single line. If anyone still wants to optimize more, they can always set recommendations: false in the config file.

[codenio]

@PrasadG193 requested changes were implemented. I guess it's ready now. Let's get it merged.

[PrasadG193]

Great work, @aananthraj !! 🎉

[codenio]

Thanks @PrasadG193 for the extended support 👍