[feature] Add Object Annotation filter, Fixes #132, #133 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenio
force-pushed
the
feature/annotation-filter
branch
from
531b9e5 to
5a39342
Compare
|
rebased to develop |
PrasadG193
approved these changes
Aug 5, 2019
|
Thanks for the PR @aananthraj! Please rebase your branch with develop. |
codenio
force-pushed
the
feature/annotation-filter
branch
from
5a39342 to
84d12fa
Compare
|
@PrasadG193, Rebased to develop. thanks 👍 |
sanketsudake
reviewed
Aug 5, 2019
sanketsudake
reviewed
Aug 5, 2019
codenio
force-pushed
the
feature/annotation-filter
branch
2 times, most recently
from
afca609 to
b1c42ba
Compare
|
Resolved requested changes. |
codenio
force-pushed
the
feature/annotation-filter
branch
from
b1c42ba to
81e745e
Compare
|
Rebased onto develop |
codenio
force-pushed
the
feature/annotation-filter
branch
2 times, most recently
from
b8ee76d to
273bbce
Compare
sanketsudake
reviewed
Aug 9, 2019
pkg/filterengine/filters/object-annotation-filter/object_annotation_checker.go
Outdated
Show resolved
Hide resolved
This commit, - enables filtering of events based on annotations present in objects at run time. - annotation `botkube.io/disable: true` disables event notifications for the annotated object - annotation `botkube.io/channel: <channel_name>` sends events notifications of the annotated object to the mentioned channel. - adds func `ExtractAnnotations()`. It extract annotations from Event.InvolvedObject and adds them to event.Metadata.Annotations - implements individual actions using internal functions. - adds unit tests for internal functions. - replaces Init() with InitialiseKubeClient() to decouple config.yaml and KubeClinet dependencies from unit testing
codenio
force-pushed
the
feature/annotation-filter
branch
from
273bbce to
88dbb3e
Compare
codenio
commented
Aug 12, 2019
| expectedChannel string | ||
| expectedBool bool | ||
| }{ | ||
| `Empty ObjectMeta`: {metaV1.ObjectMeta{}, "", false}, |
There was a problem hiding this comment.
I guess, this covers the emty object use case as well as the object not available (object deleted) use case.
Do correct me, if am missing something.
sanketsudake
approved these changes
Aug 12, 2019
|
@aananthraj Please rebase PR. |
|
Sure, thanks |
PrasadG193
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
This commit,
botkube.io/disable: truedisables event notifications for the annotated objectbotkube.io/channel: <channel_name>sends events notifications of the annotated object to the mentioned channel.utils.ExtractAnnotations(). It extracts annotations from Event.InvolvedObject. Extracted Annotations are then added to the event.Metadata.Annotationsutils.Init()withInitialiseKubeClient()to decoupleconfig.yamlandKubeClinetdependencies from unit testingFixes #132
Adding
botkube.io/channel: <channel_name>annotation to a kubenetes resources sends all the notifications of the annotated object to specified channel in the workspace.This provides a way to classify notifications based on internal teams or workgroup by using the annotation data available in the resources.
Fixes #133
Adding
botkube.io/disable: trueannotation to a kubernetes resource, skips the notifications about the annotated object from being sent to the channels.This provides us the control to enable or disable notifications of a particular object at run time.
Up