add proxyURL, deployment env variable if-loop #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about adding a section like Reference: |
PrasadG193
approved these changes
Aug 17, 2019
|
@bhavin192 sounds good to me. @rajinator could you please make those changes? |
|
@PrasadG193 @bhavin192 @sanketsudake changes added, also added new issues #160 and #161 |
sanketsudake
approved these changes
Aug 19, 2019
PrasadG193
reviewed
Aug 19, 2019
PrasadG193
approved these changes
Aug 20, 2019
|
PR merged, thanks @rajinator ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Adding Support for Basic Proxy
Need a proxy configured to use the proxy value. If statement in deployment.yaml will make sure deployment doesn't fail, if proxy is not being used
Fixes #155