Node Level Critical Events filter #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codenio
force-pushed
the
feature/node-event-filter
branch
2 times, most recently
from
d76e4e7 to
ff21d65
Compare
|
rebased onto develop |
PrasadG193
reviewed
Aug 19, 2019
codenio
force-pushed
the
feature/node-event-filter
branch
2 times, most recently
from
9b26385 to
c0deccc
Compare
sanketsudake
approved these changes
Aug 20, 2019
codenio
force-pushed
the
feature/node-event-filter
branch
from
c0deccc to
1bd7087
Compare
|
rebased onto develop. |
PrasadG193
requested changes
Aug 20, 2019
codenio
force-pushed
the
feature/node-event-filter
branch
from
1bd7087 to
a1b6a2a
Compare
PrasadG193
reviewed
Aug 20, 2019
This Commit - Allows kubernetes events of `Warning` Type as ErrorEvents - Allows kubernetes events of `Normal` Type as Insignificant InfoEvents - Adds `NodeEventsChecker` filter to check for Node InfoEvents with critical reasons like `NodeNotReady` ,`NodeReady`. - InfoEvents with critical reasons are promoted as significant Node ErrorEvents - Post events filtering, unpromoted Insignificant `InfoEvents` are skipped.
codenio
force-pushed
the
feature/node-event-filter
branch
from
a1b6a2a to
e465f94
Compare
PrasadG193
approved these changes
Aug 21, 2019
|
Merged. Thanks @aananthraj ! |
|
@PrasadG193 thanks for the support 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
This PR,
WarningType asErrorEventsNormalType as InsignificantInfoEventsNodeEventsCheckerfilter to check for Node InfoEvents with critical reasons likeNodeNotReady,NodeReady.InfoEventswith critical reasons are promoted as significant NodeErrorEventsInfoEventsare skipped.Fixes #134
Preview
