Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Remove vendor #166

Merged
merged 1 commit into from
Aug 26, 2019
Merged

[cleanup] Remove vendor #166

merged 1 commit into from
Aug 26, 2019

Conversation

PrasadG193
Copy link
Collaborator

ISSUE TYPE
  • Code cleanup Pull Request
SUMMARY
  • Remove vendoring since we have switched to go modules
  • Update Dockerfile to use go mod

Fixes #165

@PrasadG193 PrasadG193 added the refactor Code refactoring. No functional changes label Aug 26, 2019
@codenio
Copy link
Contributor

codenio commented Aug 26, 2019

we could add vendor dir under .gitignore as well.

@PrasadG193
Copy link
Collaborator Author

Yes, thanks @aananthraj

@PrasadG193
Remove vendoring since we have switched to go modules
69f454b 
Update Dockerfile to use go mod
Add .gitignore

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193 PrasadG193 merged commit c4b6913 into kubeshop:develop Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees

@sanketsudake sanketsudake

Labels
refactor Code refactoring. No functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cleanup] Remove vendor
3 participants
@PrasadG193 @codenio @sanketsudake