Expose prometheus metrics for BotKube #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surbhidongaonkar
force-pushed
the
surbhi-botkube
branch
3 times, most recently
from
9d8463d to
2cbf531
Compare
PrasadG193
reviewed
Nov 26, 2019
helm/botkube/templates/service.yaml
Outdated
| @@ -0,0 +1,26 @@ | |||
| {{- if .Values.service }} | |||
| {{- range $port := .Values.service.ports }} | |||
| {{- $service_type := $port.type | default "ClusterIP" }} | |||
There was a problem hiding this comment.
@Surbhidongaonkar We shouldn't be creating service if serviceMonitor.enabled is not set true
There was a problem hiding this comment.
Have modified service.yaml with required changes
Surbhidongaonkar
force-pushed
the
surbhi-botkube
branch
from
2cbf531 to
b62c493
Compare
PrasadG193
reviewed
Nov 27, 2019
Surbhidongaonkar
force-pushed
the
surbhi-botkube
branch
from
b62c493 to
6113a33
Compare
PrasadG193
approved these changes
Nov 28, 2019
bhavin192
suggested changes
Nov 28, 2019
cmd/botkube/main.go
Outdated
| @@ -30,6 +30,9 @@ func main() { | |||
| go mb.Start() | |||
| } | |||
|
|
|||
| //Prometheus metrics | |||
There was a problem hiding this comment.
Small typo here: space after //
Surbhidongaonkar
force-pushed
the
surbhi-botkube
branch
from
6113a33 to
1e8ab1c
Compare
Surbhidongaonkar
force-pushed
the
surbhi-botkube
branch
from
1e8ab1c to
9b83c42
Compare
Surbhidongaonkar
changed the title
bhavin192
approved these changes
Nov 29, 2019
PrasadG193
reviewed
Nov 29, 2019
pkg/metrics/metrics.go
Outdated
| // ServeMetrics exposes metrics in Prometheus format | ||
| func ServeMetrics() { | ||
| http.Handle("/metrics", promhttp.Handler()) | ||
| http.ListenAndServe(":2112", nil) |
There was a problem hiding this comment.
@Surbhidongaonkar We should read port from env var. Something like METRICS_PORT. And pass that env variable through deployment spec (like https://github.com/infracloudio/botkube/blob/develop/helm/botkube/templates/deployment.yaml#L41)
Surbhidongaonkar
force-pushed
the
surbhi-botkube
branch
2 times, most recently
from
4b5f93d to
a93ccd0
Compare
Surbhidongaonkar
force-pushed
the
surbhi-botkube
branch
from
a93ccd0 to
5c5acb7
Compare
PrasadG193
approved these changes
Nov 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Adding prometheus which exposes different metrics from botkube like no of resources scanned, no of goroutines that currently exist etc.
Fixes ##182
Dependencies: github.com/prometheus/client_golang/prometheus/promhttp