Fix panic when running command without resource #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsdejong
changed the title
|
Hey @thijsdejong, thanks for fixing this. Do you mind adding test for this in our e2e test suite? https://github.com/infracloudio/botkube/blob/develop/test/e2e/command/kubectl.go#L46 |
I added the test |
PrasadG193
approved these changes
Feb 2, 2021
|
@thijsdejong CI failures are blocking merge. Could you please take a look? |
PrasadG193
reviewed
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
This fixes a panic when running a command with an allowed verb but without a resource. For example:
@Botkube get.