allow configuration of Mattermost Username #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goir
force-pushed
the
configurable-mattermost-user
branch
from
9a2288e to
f7290a1
Compare
PrasadG193
reviewed
Feb 12, 2021
There was a problem hiding this comment.
Thanks for the PR @goir. I just have a minor comment, the rest looks good.
goir
force-pushed
the
configurable-mattermost-user
branch
from
0c41b74 to
12fab4a
Compare
|
Hi @PrasadG193 sorry for the delay. I've changed the name as you suggested. If there is anything else, just let me know. |
PrasadG193
reviewed
Feb 19, 2021
goir
force-pushed
the
configurable-mattermost-user
branch
2 times, most recently
from
804096c to
0c89897
Compare
goir
force-pushed
the
configurable-mattermost-user
branch
from
0c89897 to
b6d2bbd
Compare
PrasadG193
approved these changes
May 12, 2021
PrasadG193
changed the title
This was referenced Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Allow Configuration of Mattermost user and fixes BUG with getUser() if its not the "BotKube" default user.
Fixes #245