Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing communications config as a k8s secret using existingSecret #482

Merged
merged 4 commits into from
May 25, 2021
Merged

Passing communications config as a k8s secret using existingSecret #482

merged 4 commits into from
May 25, 2021

Conversation

ebrianne
Copy link
Contributor

@ebrianne ebrianne commented May 6, 2021

ISSUE TYPE
  • Feature Pull Request
SUMMARY

I have implemented in the helm chart the possibility to pass the communication config as a k8s secret and configure in the value files via an existingSecret. It can be configured in the values file via these:

communications:
    existingSecret: false
    existingSecretName: ""

Fixes #319 #211 #226 #233

Copy link
Contributor

@bhavin192 bhavin192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating the change, this looks good to me. I have suggested a change related to name of the secret.

@pierluigilenoci
Copy link
Contributor

@ebrianne could you please implement the suggestion in your PR?

@ebrianne
Copy link
Contributor Author

I will implemented the changes as soon as I have time... today won't be possible. I ll try over the week end.

@pierluigilenoci
Copy link
Contributor

@ebrianne any news?

@ebrianne
Copy link
Contributor Author

I have just pushed the suggested changes

@pierluigilenoci
Copy link
Contributor

@bhavin192 could you please take a look?

@pierluigilenoci
Copy link
Contributor

@PrasadG193 could you please take a look?

@ebrianne ebrianne requested a review from bhavin192 May 25, 2021 07:27
@pierluigilenoci
Copy link
Contributor

@ebrianne now it's your turn 😜

@ebrianne ebrianne requested a review from bhavin192 May 25, 2021 10:24
@pierluigilenoci
Copy link
Contributor

i8O0J31
😆

Copy link
Contributor

@bhavin192 bhavin192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚀

@mergify mergify bot merged commit 20f988d into kubeshop:develop May 25, 2021
@ebrianne ebrianne deleted the feature/helm-k8s-secret branch May 25, 2021 13:08
@onedr0p
Copy link

onedr0p commented Jun 10, 2021

Please push a new release of the chart this is very much needed 🙏🏼

@rhummelmose
Copy link

Why isn't a Helm chart with this released yet?

samip5 added a commit to samip5/k8s-cluster that referenced this pull request Aug 6, 2021
@pierluigilenoci
Copy link
Contributor

@rhummelmose nope. 😢

@pierluigilenoci
Copy link
Contributor

@bhavin192 @PrasadG193 can you help to make a release?

@PrasadG193
Copy link
Collaborator

Hey @pierluigilenoci, I am already working on it. We will make a release this week. Sorry for the delay.

@rhummelmose
Copy link

Thanks, really need this (y)

@onedr0p
Copy link

onedr0p commented Aug 11, 2021

@PrasadG193 could you please also make the GHCR image the default in the chart <3

#498

@rhummelmose
Copy link

@PrasadG193 Is this coming? :)

@onedr0p
Copy link

onedr0p commented Aug 17, 2021

What's holding up the release, do you all need help on anything?

@Israphel
Copy link

How do I use this? what's the format of the secret to create?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load secret info from k8s Secret objects.
7 participants