-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing communications config as a k8s secret using existingSecret #482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating the change, this looks good to me. I have suggested a change related to name of the secret.
@ebrianne could you please implement the suggestion in your PR? |
I will implemented the changes as soon as I have time... today won't be possible. I ll try over the week end. |
@ebrianne any news? |
I have just pushed the suggested changes |
@bhavin192 could you please take a look? |
@PrasadG193 could you please take a look? |
@ebrianne now it's your turn 😜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🚀
Please push a new release of the chart this is very much needed 🙏🏼 |
Why isn't a Helm chart with this released yet? |
@rhummelmose nope. 😢 |
@bhavin192 @PrasadG193 can you help to make a release? |
Hey @pierluigilenoci, I am already working on it. We will make a release this week. Sorry for the delay. |
Thanks, really need this (y) |
@PrasadG193 could you please also make the GHCR image the default in the chart <3 |
@PrasadG193 Is this coming? :) |
What's holding up the release, do you all need help on anything? |
How do I use this? what's the format of the secret to create? |
ISSUE TYPE
SUMMARY
I have implemented in the helm chart the possibility to pass the communication config as a k8s secret and configure in the value files via an existingSecret. It can be configured in the values file via these:
Fixes #319 #211 #226 #233