Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Implement Quota #5

Open
ingowalther opened this issue Oct 10, 2016 · 7 comments
Open

Feature: Implement Quota #5

ingowalther opened this issue Oct 10, 2016 · 7 comments
Labels
enhancement Hacktoberfest help wanted

Comments

@ingowalther
Copy link
Owner

Implement Quota per User.
@denis-n-ko
Copy link

Hello, i'll take it.

@ingowalther
Copy link
Owner Author

@denis-n-ko thank you!

@denis-n-ko
Copy link

Hello, btw is there any requirements for this feature?
Now i am implementing it in the following way:

  1. Each apiKey will have some count of available quota.
  2. 1 quota will be burned when api is used.
  3. If apiKey will not have available quota, api request will be rejected.

@ingowalther
Copy link
Owner Author

Hello,

your plan sounds good to me.
A good feature would be a quota in a range of time. e.g.: the user can make 100 api calls per day.

Greetings
Ingo

@ingowalther
Copy link
Owner Author

This issue is still open.

@luchianenco
Copy link
Contributor

what do you think to use Redis to track quota?
We will reduce the processing and response time in this way

@luchianenco
Copy link
Contributor

Started implementation - added 3 db fields for user
quote per month, day and hour, updated user:add and user:list command
working on, using redis as data storage for quota calculations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@denis-n-ko @luchianenco @ingowalther