Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight incompatibility with Cheerio regarding doctypes #13

Closed
cvrebert opened this issue Mar 1, 2015 · 1 comment
Closed

Slight incompatibility with Cheerio regarding doctypes #13

cvrebert opened this issue Mar 1, 2015 · 1 comment

Comments

@cvrebert
Copy link

cvrebert commented Mar 1, 2015

Whacko(/Parse5 (?)) strips out SYSTEM when parsing the HTML5 doctype legacy string; Cheerio doesn't:

$ node
> require('cheerio').load('<!DOCTYPE html SYSTEM "about:legacy-compat"><html><head></head><body>Hi there!</body></html>')(':root')[0].prev.data 
'!DOCTYPE html SYSTEM "about:legacy-compat"'
> require('whacko').load('<!DOCTYPE html SYSTEM "about:legacy-compat"><html><head></head><body>Hi there!</body></html>')(':root')[0].prev.data 
'!DOCTYPE html "about:legacy-compat"'

Versions I'm using:

  • cheerio@0.18.0
  • whacko@0.17.4
This was referenced Mar 1, 2015
Closed
Closed
@inikulin
Copy link
Owner

inikulin commented Apr 8, 2015

It's actually a bug in parse5's htmlparse2 tree adapter. Reopening bug there.

@inikulin inikulin closed this as completed Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvrebert @inikulin