Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesttions / Improvements #12

Closed
inishchith opened this issue Mar 16, 2019 · 11 comments
Closed

Suggesttions / Improvements #12

inishchith opened this issue Mar 16, 2019 · 11 comments

Comments

@inishchith
Copy link
Owner

  • This Section is for improvements and suggestions over the microtasks performed.
@valeriocos
Copy link
Collaborator

Thank you @inishchith for sharing the repo. I had a look to your microtasks and overall they look great.
If you agree, I would open an issue per microtask, so all comments/feedback for a given microtask will be isolated from the other ones.

I read that you have already worked with scancode (https://github.com/inishchith/chaoss-microtasks/tree/master/microtask-9#--optional-). That's indeed a good news, could you tell me what you did with scancode ?

Thank you!

@inishchith
Copy link
Owner Author

inishchith commented Mar 16, 2019

If you agree, I would open an issue per microtask, so all comments/feedback for a given microtask will be isolated from the other ones.

Sure. I've opened Microtask #*. Issues. We can have discussion over there ;)

I read that you have already worked with scancode (https://github.com/inishchith/chaoss-microtasks/tree/master/microtask-9#--optional-). That's indeed a good news, could you tell me what you did with scancode ?

Thanks. I have worked on couple of problems and documentation work.

  1. Limit number of urls and emails reported in a single file #384 Merged
  • The problem was related to number of emails reported from the licenses. Sometimes this number used to be too large hence after some suggestions I worked on adding an option in order to restrict the number of emails reported per file solving this issue. Then there used to be intense work to be done on the plugin-architecture as you can see on the issue thread.
  1. Add STMicroelectronics license Merged
  • Here i worked on adding a STMicroelectronics license ( Permissive Free License ) to the existing set of available licenses.
  1. Adopt a code of conduct #301 Open

@valeriocos
Copy link
Collaborator

Thank you for the info!

@inishchith
Copy link
Owner Author

@valeriocos Thanks for the feedback on the issue tickets, I'll have a look one by one and resolve them ;)

@inishchith
Copy link
Owner Author

@valeriocos I've updated the repository with the suggestions given on each issue ticket. Please do have a look and let me know if you've got some suggestions . Thanks :)

@valeriocos
Copy link
Collaborator

Perfect @inishchith , I'll have a look at it today, thanks

@valeriocos
Copy link
Collaborator

Hi @inishchith I have just had a look to your repo. Everything looks OK, I left just a minor comment for microtask-3 #4

Thank you for your work

@inishchith
Copy link
Owner Author

@valeriocos Thanks for the review. I've updated the repository after having a look at your comments at #4 . :)

@valeriocos
Copy link
Collaborator

you're welcome @inishchith :)

@inishchith
Copy link
Owner Author

@valeriocos I had closed some of the issues, thought they were resolved after your suggestions. Do let me know if that's okay.

@valeriocos
Copy link
Collaborator

They look ok, thanks for addressing my comments @inishchith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants