Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for Promise<PlacesLibrary> in GoogleMap's api-promise prop #251

Open
kacperorzechowski opened this issue Apr 18, 2024 · 2 comments
Labels
enhancement New feature or request types

Comments

@kacperorzechowski
Copy link

When I am trying to use Loader to load GoogleMaps I have deprecation warning that says: "Vue: The signature (): Promise<typeof google> of loader.load is deprecated." And it suggests to use below method instead:

loader.importLibrary('places');

Problem here is that GoogleMap component's prop api-promise is not supporting Promise<PlacesLibrary>, which comes from:

const apiPromise2 = loader.importLibrary('places');

So it forces us to use deprecation method right now.
Package version: "vue3-google-map": "^0.20.0"

@HusamElbashir HusamElbashir added enhancement New feature or request types labels Apr 18, 2024
@Aqual0n
Copy link

Aqual0n commented Jun 13, 2024

Same issue here.

@lbineau
Copy link

lbineau commented Aug 26, 2024

Same issue. I also think googlemaps/js-api-loader could improve the way they handle the main function deprecation from their API without updating their documentation nor providing a migration guide. (see related issue googlemaps/js-api-loader#837)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request types
Projects
None yet
Development

No branches or pull requests

4 participants