Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(spoof-player-parameters): playback issue persists despite spoofing applied #1238

Closed
5 tasks done
laethy1 opened this issue Jul 26, 2023 · 38 comments
Closed
5 tasks done
Labels
A/B test Reproducible only in some users Bug report Something isn't working

Comments

@laethy1
Copy link

laethy1 commented Jul 26, 2023

Type

Error at runtime

Tools used

ReVanced Manager

Application

YouTube v18.27.35

Bug description

Video stuck loading but enabling spoof player parameters doesn't work

Steps to reproduce

N/A

Relevant log output

N/A

Screenshots or videos

Record_2023-07-26-22-58-04.mp4

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
  • I have written the title and contents in English.
  • This issue does not reproduce on unpatched YouTube or YT Music.
@laethy1 laethy1 added the Bug report Something isn't working label Jul 26, 2023
@inotia00

This comment was marked as outdated.

@inotia00
Copy link
Owner

ah, I checked
looks like a valid issue

@inotia00 inotia00 changed the title Video stuck loading bug(spoof-player-parameters): playback issue persists despite spoofing applied Jul 26, 2023
@inotia00 inotia00 pinned this issue Jul 26, 2023
@KobeW50
Copy link
Contributor

KobeW50 commented Jul 26, 2023

@laethy1 Did you just enable the spoof before recording? Because you need to restart the app after changing any of the spoof toggles in order to take effect

@laethy1
Copy link
Author

laethy1 commented Jul 26, 2023

@laethy1 Did you just enable the spoof before recording? Because you need to restart the app after changing any of the spoof toggles in order to take effect

It was already enabled at the start when I patched the app

@inotia00 inotia00 added the A/B test Reproducible only in some users label Jul 27, 2023
@Spacellary
Copy link
Collaborator

Spacellary commented Jul 27, 2023

Last seen on this issue here: ReVanced/revanced-patches#2432

Could be related?


I also noticed that the whole video gets bugged if you let it hit 1:09, and the only quality options you can chose regardless of the video are 144p, 360p and 720p.

@inotia00
Copy link
Owner

Nothing is certain yet

For optimal testing, please set up the following environment

  • patch to YouTube v18.20.39
  • turn on spoof player parameters
  • change the spoof player parameter type to incognito mode

Test to see if the playback issue reproduces

@Spacellary
Copy link
Collaborator

Spacellary commented Jul 27, 2023

I am also not affected by this issue yet so I can't provide feedback, but for those that are, please provide feedback when possible after testing as needed.

@Shailesh2002
Copy link

There is no such option in miscellaneous

@Spacellary
Copy link
Collaborator

There is no such option in miscellaneous

@Shailesh2002 Hey! We're looking for these options:

Screenshot_2023-07-27-16-11-58-574_app.rvx.android.youtube.png

Can you please share your complete Patch log? It seems something either went wrong or you're missing by not including a required Patch...

Also just for completeness sake report the version of YouTube and patches version you're reporting from now, and weather or not you're using the Default recommend list of patches.

@Shailesh2002
Copy link

Shailesh2002 commented Jul 27, 2023

There is no such option in miscellaneous

@Shailesh2002 Hey! We're looking for these options:

Screenshot_2023-07-27-16-11-58-574_app.rvx.android.youtube.png

Can you please share your complete Patch log? It seems something either went wrong or you're missing by not including a required Patch...

Also just for completeness sake report the version of YouTube and patches version you're reporting from now, and weather or not you're using the Default recommend list of patches.

@Spacellary

Screenshot_20230728-032149_YouTube.jpg

Screenshot_20230728-032221_YouTube.jpg

Screenshot_20230728-032101_YouTube.jpg

@KobeW50
Copy link
Contributor

KobeW50 commented Jul 27, 2023

@Shailesh2002 update

@Shailesh2002
Copy link

Shailesh2002 commented Jul 27, 2023

@Shailesh2002 update

@KobeW50
They asked for screenshot of my vanced settings...

@Spacellary
Copy link
Collaborator

Spacellary commented Jul 27, 2023

@Shailesh2002 – We need testing with the Latest patches and in the YouTube version specified.

You need to update. Your version is very old and that's what is causing your issues. If you update it will very likely work fine.

You don't even have the fix for the issue in your application.

If you want I can provide an APK with the requirments for your testing that you can install without affecting your current application. Let me know and I'll share with you.

This is intended only as a means to ease the testing and providing a controllable version for testing.

@KobeW50
Copy link
Contributor

KobeW50 commented Jul 27, 2023

@Shailesh2002 – We need testing with the Latest patches and in the YouTube version specified.

You need to update. Your version is very old and probably what is causing issues. If you update it will likely work fine.

If you want I can provide an APK with the requirments for your testing that you can install without affecting your current application. Let me know and I'll share with you.

This is intended only as a means to ease the testing and providing a controllable version for testing.

For testing, inotia00 said to use 18.20.39

@Spacellary
Copy link
Collaborator

Spacellary commented Jul 27, 2023

For testing, inotia00 said to use 18.20.39

I can make a Pre-Release version with the specific version and a different package name to make it available as necessary for testing purposes.

@Shailesh2002
Copy link

@Shailesh2002 – We need testing with the Latest patches and in the YouTube version specified.

You need to update. Your version is very old and that's what is causing your issues. If you update it will very likely work fine.

You don't even have the fix for the issue in your application.

If you want I can provide an APK with the requirments for your testing that you can install without affecting your current application. Let me know and I'll share with you.

This is intended only as a means to ease the testing and providing a controllable version for testing.

@Spacellary

Provide apk so that I can install new version

@Spacellary
Copy link
Collaborator

@Shailesh2002 you can patch the one Kobe provided using the latest RVX Manager.

@Shailesh2002
Copy link

@Shailesh2002 you can patch the one Kobe provided using the latest RVX Manager.

@Spacellary
Please provide download link

@Spacellary
Copy link
Collaborator

Spacellary commented Jul 28, 2023

Please provide download link

@Shailesh2002 -- Please beware that you must patch your own Revanced Extended, I am just another user trying to help and I'll link you this testing build for you to use just to validade the issue or not.

Report back as soon as possible after testing it...

Re-youtube-182039-output.apk

@Spacellary
Copy link
Collaborator

Spacellary commented Jul 28, 2023

@Shailesh2002 For the principle of testing I provided a link to a pre-release version you can use to validade the issue, as I said please report back once you have it set as instructed:

Settings -> Revanced Extended -> Miscellaneous:

  • turn on spoof player parameters

  • change the spoof player parameter type to incognito mode

@KobeW50
Copy link
Contributor

KobeW50 commented Jul 28, 2023

Can u give me latest version apk

If you want to patch the currently suggested apk version you can follow this guide

Support can be given in the subreddit if you need. This issue thread is only for the original issue of the author.

@Shailesh2002
Copy link

@Shailesh2002 For the principle of testing I provided a link to a pre-release version you can use to validade the issue, as I said please report back once you have it set as instructed:

  • turn on spoof player parameters

  • change the spoof player parameter type to incognito mode

@Spacellary

Hey...thanks for helping me
But I don't know how to test and all
Please u only do something...if anything goes wrong it would problem

@Spacellary
Copy link
Collaborator

@Shailesh2002 -- Alright my friend unfortunately this is far as I can help, go to the subreddit and follow the Pinned Guide for Beginners to get updated. This is related to the issue reported and looks like it isn't your case.

@Shailesh2002
Copy link

@Shailesh2002 -- Alright my friend unfortunately this is far as I can help, go to the subreddit and follow the Pinned Guide for Beginners to get updated. This is related to the issue reported and looks like it isn't your case.

@Spacellary
I am new to this github so I don't where to go for subreddit

@Spacellary
Copy link
Collaborator

@Shailesh2002 Here you go.

@Shailesh2002
Copy link

@Shailesh2002 Here you go.

@Spacellary

Thank you so much sir

@Qanaden
Copy link

Qanaden commented Jul 28, 2023

I've had this issue as well. I patched to 18.20.39 turned on spoof player parameter and spoof player parameter type. I have every battery optimization and data saver setting I can find turned off even battery protect (limit to 85%.) I set both the manager and apps battery settings to unrestricted. I still have the issue it'll run for about 3 minutes when the screen is off then stop.

@Spacellary
Copy link
Collaborator

Spacellary commented Jul 28, 2023

@Qanaden The issue you are referring to is a different one, we are testing playback with screen on stopping after ~1m10s.

How is that?

Your issue seems to be this one: https://github.com/ReVanced/revanced-patches-template/issues/847

@Qanaden
Copy link

Qanaden commented Jul 28, 2023

@Qanaden The issue you are referring to is a different one, we are testing playback with screen on stopping after ~1m10s.

How is that?

Your issue seems to be this one: https://github.com/ReVanced/revanced-patches-template/issues/847

Idk I'm following the link I got on reddit in the post I made on the revanced extended sub. I have used revanced and had the same issue on there as well but atm I'm using revanced extended.

@Spacellary
Copy link
Collaborator

Spacellary commented Jul 28, 2023

@Qanaden

Yeah yeah just saying you were linked this one, I might have been mistaken. Sorry if that's the case.

Screenshot_2023-07-28-01-42-34-855_com.laurencedawson.reddit_sync.png

If you face playback issues let us know 👍

@savvaki

This comment was marked as off-topic.

@inotia00
Copy link
Owner

I am using the prebuilt APKs.

I do not provide support for issues arising from using prebuilt APKs.

@savvaki
Copy link

savvaki commented Jul 28, 2023

I am using the prebuilt APKs.

I do not provide support for issues arising from using prebuilt APKs.

Just providing info, since multiple versions are failing at once, perhaps that could help with debugging. Otherwise, thanks for the speedy response and good luck!

@Spacellary
Copy link
Collaborator

How to hide that which I have circled

This is not the place for this, please ask questions in the general community channels like Reddit for example, this place is for discussion of issues only.

@Shailesh2002

This comment was marked as duplicate.

Repository owner locked as too heated and limited conversation to collaborators Jul 28, 2023
@inotia00
Copy link
Owner

fixed in revanced-patches-v2.186.10

@inotia00 inotia00 unpinned this issue Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A/B test Reproducible only in some users Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants