Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(YouTube): Back swipe from search should go to RVX settings, not YouTube settings #2723

Open
5 tasks done
ILoveOpenSourceApplications opened this issue Jan 21, 2025 · 3 comments
Labels
Suggestion Leave any other suggestions

Comments

@ILoveOpenSourceApplications
Copy link

ILoveOpenSourceApplications commented Jan 21, 2025

Application

YouTube

Suggestion description

After searching anything and back swiping from that search takes the user out of RVX settings and straight to YouTube settings.

Screen_Recording_20250121_123356_YouTube.mp4

Instead after swiping out from the search, the user should remain within RVX settings.

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Suggestion Leave any other suggestions label Jan 21, 2025
@anddea
Copy link

anddea commented Jan 23, 2025

Reflected in this commit anddea/revanced-patches@0a7e761. The relevant code lines.

Taking advantage of the moment, I'd like to suggest syncing not only the search functionality, but also prefs icons and the XML preferences (including their order, recent grouping attributes, etc). Together, these elements improve overall user experience.

Expand As I mentioned before, I've reordered some settings mostly based on the same appearance order as in the actual YouTube layout, like buttons order, flyout menu (bottom sheet) elements and other components. Those changes are more noticeable when the `Visual preferences icons` setting is enabled (along with the `applyToAll` option), making navigation easier overall. I genuinely believe that ordering preferences alphabetically (which is in English only) is not ideal, especially since ReVanced's preferences differ from those of RVX anyway, if we assume that it's the case of the current prefs' order.

@YT-Advanced
Copy link

YT-Advanced commented Jan 24, 2025

Can u open a PR @anddea 👀

@anddea
Copy link

anddea commented Jan 24, 2025

Our repos are currently detached, so I cannot open a PR, but the main issue is different, my prefs xml file contains some additional prefs and since it's reordered, previously inotia00 declined these changes. And the latest search fragment update includes new dependency attribute inside prefs xml which can be ignored but there's no reason to update search functionality then. The search fragment code (but not prefs xml) and visual prefs icons can be easily cherry-picked with no conflicts, so I'm not sure if I really need to open a PR for this, since it will be the same as squash and merge. If it's okay to have the same order for prefs as in my repo, I can create a PR easily, since I have automation code for it (including the determination of additional prefs, but not reordering logic because prefs xml is commented and it is hard to automate it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

3 participants