Refactor: Update GenesisKeyhash to use consistent hash types and improve error handling in tx_unpacker

Author: lowhung

codec/src/map_parameters.rs

@@ -37,8 +37,8 @@ pub fn to_hash<const N: usize>(pallas_hash: &pallas_primitives::Hash<N>) -> Hash
 
 /// Convert a Pallas Hash reference to an Acropolis Hash (owned)
 /// Works for any hash size N
-pub fn genesis_to_hash(pallas_hash: &pallas_primitives::Genesishash) -> GenesisKeyhash {
-    GenesisKeyhash::try_from(pallas_hash.as_ref()).unwrap()
+pub fn genesis_to_hash(pallas_hash: &pallas_primitives::Genesishash) -> Hash<32> {
+    Hash::try_from(pallas_hash.as_ref()).unwrap()
 }
 
 /// Convert a Pallas Hash reference to an Acropolis Hash (owned)

common/src/types.rs

@@ -450,7 +450,7 @@ pub type ScriptHash = KeyHash;
 pub type AddrKeyhash = KeyHash;
 
 /// Script identifier
-pub type GenesisKeyhash = Hash<32>;
+pub type GenesisKeyhash = Hash<28>;
 
 declare_hash_type!(BlockHash, 32);
 declare_hash_type!(TxHash, 32);
@@ -982,7 +982,7 @@ pub struct SPORewards {
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 pub struct GenesisKeyDelegation {
     /// Genesis hash
-    pub genesis_hash: GenesisKeyhash,
+    pub genesis_hash: Hash<32>,
 
     /// Genesis delegate hash
     pub genesis_delegate_hash: PoolId,

modules/tx_unpacker/src/tx_unpacker.rs

@@ -49,16 +49,23 @@ impl TxUnpacker {
             enactment_epoch: epoch,
         };
 
-        for (hash, vote) in proposals.iter() {
+        for (hash_bytes, vote) in proposals.iter() {
+            let hash = match GenesisKeyhash::try_from(hash_bytes.as_ref()) {
+                Ok(h) => h,
+                Err(e) => {
+                    error!("Invalid genesis keyhash in protocol parameter update: {e}");
+                    continue;
+                }
+            };
+
             match map(vote) {
-                Ok(upd) => update.proposals.push((hash.to_vec(), upd)),
-                Err(e) => error!("Cannot convert alonzo protocol param update {vote:?}: {e}"),
+                Ok(upd) => update.proposals.push((hash, upd)),
+                Err(e) => error!("Cannot convert protocol param update {vote:?}: {e}"),
             }
         }
 
         dest.push(update);
     }
-
     /// Main init function
     pub async fn init(&self, context: Arc<Context<Message>>, config: Arc<Config>) -> Result<()> {
         // Get configuration