Refactor: Replace Vec<u8> with PoolId and add Bech32 (de)serialization support

Author: lowhung

common/src/serialization.rs

@@ -4,6 +4,7 @@ use anyhow::anyhow;
 use bech32::{Bech32, Hrp};
 use serde::{ser::SerializeMap, Deserialize, Serializer};
 use serde_with::{ser::SerializeAsWrap, DeserializeAs, SerializeAs};
+use crate::PoolId;
 
 pub struct SerializeMapAs<KAs, VAs>(std::marker::PhantomData<(KAs, VAs)>);
 
@@ -60,7 +61,31 @@ impl HrpPrefix for AddrPrefix {
 // Generic Bech32 converter with HRP parameter
 pub struct DisplayFromBech32<PREFIX: HrpPrefix>(PhantomData<PREFIX>);
 
-// Serialization implementation
+// PoolID serialization implementation
+impl SerializeAs<PoolId> for DisplayFromBech32<PoolPrefix>
+{
+    fn serialize_as<S>(source: &PoolId, serializer: S) -> Result<S::Ok, S::Error>
+    where
+        S: Serializer,
+    {
+        let bech32_string = source.to_bech32().map_err(serde::ser::Error::custom)?;
+        serializer.serialize_str(&bech32_string)
+    }
+}
+
+// PoolID deserialization implementation
+impl<'de> DeserializeAs<'de, PoolId> for DisplayFromBech32<PoolPrefix>
+{
+    fn deserialize_as<D>(deserializer: D) -> Result<PoolId, D::Error>
+    where
+        D: serde::de::Deserializer<'de>,
+    {
+        let s = String::deserialize(deserializer)?;
+        PoolId::from_bech32(&s).map_err(serde::de::Error::custom)
+    }
+}
+
+// Vec<u8> serialization implementation
 impl<PREFIX> SerializeAs<Vec<u8>> for DisplayFromBech32<PREFIX>
 where
     PREFIX: HrpPrefix,

modules/rest_blockfrost/src/handlers/epochs.rs

@@ -494,7 +494,7 @@ pub async fn handle_epoch_total_stakes_blockfrost(
             .to_string()
             .map_err(|e| anyhow::anyhow!("Failed to convert stake address to string: {e}"))?;
             Ok(SPDDByEpochItemRest {
-                pool_id: pool_id.to_vec(),
+                pool_id,
                 stake_address,
                 amount,
             })

modules/rest_blockfrost/src/types.rs

@@ -7,7 +7,7 @@ use acropolis_common::{
     rest_helper::ToCheckedF64,
     serialization::{DisplayFromBech32, PoolPrefix},
     AssetAddressEntry, AssetMetadataStandard, AssetMintRecord, KeyHash, PolicyAsset,
-    PoolEpochState, PoolUpdateAction, Relay, TxHash, Vote, VrfKeyHash,
+    PoolEpochState, PoolId, PoolUpdateAction, Relay, TxHash, Vote, VrfKeyHash,
 };
 use anyhow::Result;
 use num_traits::ToPrimitive;
@@ -63,7 +63,7 @@ pub struct BlockInfoREST(pub BlockInfo);
 pub struct SPDDByEpochItemRest {
     pub stake_address: String,
     #[serde_as(as = "DisplayFromBech32<PoolPrefix>")]
-    pub pool_id: Vec<u8>,
+    pub pool_id: PoolId,
     #[serde_as(as = "DisplayFromStr")]
     pub amount: u64,
 }