Replace SVAL with a function #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed this on a call, looked good - but needs squashing |
WhatisRT
force-pushed
the
andre/goguen-spec-remove-sval
branch
from
008133b
to
007e96f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is roughly how the spec would look like if SVAL was replaced with a function. Regarding errors, the only issue the way it is with this patch is that we can't return an error message telling us which script failed, if we would raise an error. We probably want that functionality, but it could be done by returning the script that failed from
evalScripts, as aMaybe ScriptHash, or maybe a list of all the scripts that didn't succeed in aList ScriptHashinstead of theBool, so this isn't a big issue.