More Mary token examples: timelocks & sigs #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2020 14:16
The evaluation of RequireTimeExpire had two problems: - The comparison of the transaction time to live with the timelock expiration should be less than or equal to, not less than. What we want is that the transaction interval is contained in the timelock interval, possibly equal to. This is not to be confused with the fact that the time to live marks the first slot that the transaction is expired. - The comparison had the transaction value and the timelock value swapped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the new examples for token minting with timelocks and signatures, I fixed two problems with the evaluation of
RequireTimeExpire: