-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plutus V2 in the Babbage Era #2661
Conversation
@@ -93,8 +93,6 @@ instance FromCBOR (Annotator Plutus.Data) where | |||
instance ToCBOR Plutus.Data where | |||
toCBOR = Cborg.encode | |||
|
|||
deriving anyclass instance NoThunks Plutus.BuiltinByteString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems Plutus.BuiltinByteString
no longer has a Generic instance to make this work. But it also does not appear to be needed anymore.
| TranslationLogicErrorDoubleDatum | ||
| LanguageNotSupported | ||
| InlineDatumsNotSupported | ||
| ReferenceScriptsNotSupported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that there is no worry of breaking predicate failure serialization here in the node-to-client protocol since these errors are never raised in the Alonzo era.
PlutusV1 | ||
(txEx unknownInput shelleyOutput emptyRedeemers) | ||
TranslationLogicErrorInput | ||
silentlyIgnore (txEx unknownInput shelleyOutput) | ||
], | ||
testGroup | ||
"Plutus V2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need a new collection of tests in the Babbage era to replace these tests, but first we need the Babbage rules to be completed.
eb34593
to
2b6c79b
Compare
826f420
to
3603038
Compare
The use of Plutus V2 is no longer tied to the protocol major version 7, but instead the Babbage era. Moreover, the transaction context for Plutus V2 now includes Babbage specific data, and V2 is now forbidden in the Alonzo era. The txInfo function from the Alonzo era is now a class method, enabling different eras to have different behavior.
3603038
to
efaca54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor suggestions, otherwise looks great
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
The use of Plutus V2 is no longer tied to the protocol major version 7, but instead the Babbage era. Moreover, the transaction context for Plutus V2 now includes Babbage specific data, and V2 is now forbidden in the Alonzo era.
The
txInfo
function from the Alonzo era is now a class method, enabling different eras to have different behavior.closes #2663