-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babbage serialization tests #2666
Conversation
import Test.Tasty.QuickCheck | ||
import Text.Show.Pretty (ppShow) | ||
|
||
trippingF :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to have a place to put common testing code like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! Let's make this a talking point next time the team meets. cardano-ledger-test
is nice for things that live "at the end of all eras", but we don't have a good place for testing support that lives "before all eras".
f864405
to
b0f2ca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through a PR overall looks pretty good. I left few comments. I'll do a proper review once the PR is finished
Sorry I commented at a wrong PR. I was reviewing another one
eras/babbage/test-suite/src/Test/Cardano/Ledger/Babbage/Serialisation/Generators.hs
Outdated
Show resolved
Hide resolved
eras/babbage/test-suite/src/Test/Cardano/Ledger/Babbage/Serialisation/Generators.hs
Outdated
Show resolved
Hide resolved
eras/babbage/test-suite/src/Test/Cardano/Ledger/Babbage/Serialisation/Generators.hs
Outdated
Show resolved
Hide resolved
eras/babbage/test-suite/src/Test/Cardano/Ledger/Babbage/Trace.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really great, thanks! I made some comments about trying to re-use generators from Alonzo, but besides that I think this is great.
b0f2ca8
to
626be16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks @goolord !
No description provided.