Emit new TotalAdaPotEvent after epoch transition (gh #2780) #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
changed the title
teodanciu
changed the title
| -- * Ada Pots | ||
| AdaPots (..), | ||
| totalAdaES, | ||
| totalAdaPotsES, |
There was a problem hiding this comment.
I think this module should re-export these three items.
to avoid calling API functions from within `NewEpoch`
kderme
reviewed
May 18, 2022
| @@ -166,6 +169,8 @@ newEpochTransition = do | |||
| -- map is empty (db-sync depends on it). | |||
| tellEvent $ TotalRewardEvent e regRU | |||
| pure es' | |||
| let adaPots = totalAdaPotsES es | |||
There was a problem hiding this comment.
As discussed in #2791 (comment) I think es''' pots better fits what we need.
There was a problem hiding this comment.
Yes! Thank you for all the explanation, I'm just about to push a new version with this.
Thanks!
teodanciu
force-pushed
the
td/new-adapots-event
branch
from
12a5a59 to
58c4000
Compare
|
Forced push to use |
teodanciu
force-pushed
the
td/new-adapots-event
branch
from
58c4000 to
c26b8bc
Compare
|
Force-pushed to retrigger build 🤞 |
teodanciu
force-pushed
the
td/new-adapots-event
branch
from
c26b8bc to
3d9f369
Compare
|
Tests are passing on my machine (even after deleting dist-newstyle), so I don't get the failure on CI. Retrying |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2791
It is a solution for: #2780
The difference is in how the code is refactored. This PR extracts
AdaPotsin a separate module (outside the API) and uses it fromNewEpoch, rather than movecalculatePoolDistrinsideWallet.API.But the question is: do these functions have to be in the API? From what I can tell, there is nothing using them at the moment, but I know little!
Are there better alternatives to this refactoring?