Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Data.Relation for tests. #2803

Merged
merged 2 commits into from
May 19, 2022
Merged

Use Data.Relation for tests. #2803

merged 2 commits into from
May 19, 2022

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented May 19, 2022

Module Data.Relation is dead code, however instead of removing it completely, I thought parts of it would make a nice small addition to the set-algebra test suite. This PR also includes cleanups to the existing set-algebra test suite: tackle disabled compilation warnings and apply hlint hints

@lehins lehins requested review from JaredCorduan and TimSheard May 19, 2022 00:37
@lehins lehins force-pushed the lehins/retire-relation branch from 1297de8 to 16ed84c Compare May 19, 2022 00:41
@lehins lehins force-pushed the lehins/retire-relation branch from 16ed84c to 1d798df Compare May 19, 2022 00:57
@lehins lehins force-pushed the lehins/retire-relation branch from 1d798df to 4eef578 Compare May 19, 2022 15:04
@@ -33,7 +33,6 @@ library
import: base, project-config

exposed-modules: Data.AbstractSize
, Data.Relation
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this, was the main goal of this PR. The rest stuff is extra 😃

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lehins lehins merged commit c97a8c8 into master May 19, 2022
@iohk-bors iohk-bors bot deleted the lehins/retire-relation branch May 19, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants