Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable staking Ptr optimization #2875

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jun 17, 2022

Unfortunately we can't make Ptr unpacking optimization until Babbage has been properly released, so this PR reverts the functionality to the 1.33/1.34 version. This indirectly relies on Address deserialization, which has been fixed in #2750, but it needs to be on mainnet, before we can unpack the Ptr.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @lehins ! Looks good to me.

@JaredCorduan
Copy link
Contributor

looks like the ci/hydra:Cardano:cardano-ledger-specs:required job timed out (on one of the mac-minis). seeing as the specs weren't even touched here, I'm going to merge.

@JaredCorduan JaredCorduan merged commit 7568bad into master Jun 18, 2022
@iohk-bors iohk-bors bot deleted the lehins/disable-ptr-optimization branch June 18, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants