fix: address PR reviews comments

- fix: synchronizer create the open messages based on the first
  certificate of the last epoch instead of the latest certificate
- move `MockCertificateVerifier` definition to `tools::mocks`
- fix spelling issues

Author: Alenar

mithril-aggregator/src/dependency_injection/builder/mod.rs

@@ -185,8 +185,8 @@ pub struct DependenciesBuilder {
     /// Genesis signature verifier service.
     pub genesis_verifier: Option<Arc<ProtocolGenesisVerifier>>,
 
-    /// Certificate chain synchroniser service
-    pub certificate_chain_synchroniser: Option<Arc<dyn CertificateChainSynchronizer>>,
+    /// Certificate chain synchronizer service
+    pub certificate_chain_synchronizer: Option<Arc<dyn CertificateChainSynchronizer>>,
 
     /// Mithril signer registration leader service
     pub mithril_signer_registration_leader: Option<Arc<MithrilSignerRegistrationLeader>>,
@@ -315,7 +315,7 @@ impl DependenciesBuilder {
             snapshotter: None,
             certificate_verifier: None,
             genesis_verifier: None,
-            certificate_chain_synchroniser: None,
+            certificate_chain_synchronizer: None,
             mithril_signer_registration_leader: None,
             mithril_signer_registration_follower: None,
             signer_registerer: None,
@@ -378,7 +378,7 @@ impl DependenciesBuilder {
             verification_key_store: self.get_verification_key_store().await?,
             epoch_settings_storer: self.get_epoch_settings_store().await?,
             chain_observer: self.get_chain_observer().await?,
-            certificate_chain_synchroniser: self.get_certificate_chain_synchroniser().await?,
+            certificate_chain_synchronizer: self.get_certificate_chain_synchronizer().await?,
             signer_registerer: self.get_signer_registerer().await?,
             signer_synchronizer: self.get_signer_synchronizer().await?,
             signer_registration_round_opener: self.get_signer_registration_round_opener().await?,

mithril-aggregator/src/dependency_injection/builder/protocol/certificates.rs

@@ -11,7 +11,7 @@ use crate::dependency_injection::{DependenciesBuilder, DependenciesBuilderError,
 use crate::get_dependency;
 use crate::services::{
     BufferedCertifierService, CertificateChainSynchronizer, CertifierService,
-    MithrilCertificateChainSynchroniserNoop, MithrilCertificateChainSynchronizer,
+    MithrilCertificateChainSynchronizer, MithrilCertificateChainSynchronizerNoop,
     MithrilCertifierService, MithrilSignerRegistrationFollower, SignerSynchronizer,
 };
 use crate::{
@@ -85,10 +85,10 @@ impl DependenciesBuilder {
         get_dependency!(self.multi_signer)
     }
 
-    async fn build_certificate_chain_synchroniser(
+    async fn build_certificate_chain_synchronizer(
         &mut self,
     ) -> Result<Arc<dyn CertificateChainSynchronizer>> {
-        let synchroniser: Arc<dyn CertificateChainSynchronizer> =
+        let synchronizer: Arc<dyn CertificateChainSynchronizer> =
             if self.configuration.is_follower_aggregator() {
                 let leader_aggregator_client = self.get_leader_aggregator_client().await?;
                 let verifier = Arc::new(MithrilCertificateVerifier::new(
@@ -105,17 +105,17 @@ impl DependenciesBuilder {
                     self.root_logger(),
                 ))
             } else {
-                Arc::new(MithrilCertificateChainSynchroniserNoop)
+                Arc::new(MithrilCertificateChainSynchronizerNoop)
             };
 
-        Ok(synchroniser)
+        Ok(synchronizer)
     }
 
     /// [CertificateChainSynchronizer] service
-    pub async fn get_certificate_chain_synchroniser(
+    pub async fn get_certificate_chain_synchronizer(
         &mut self,
     ) -> Result<Arc<dyn CertificateChainSynchronizer>> {
-        get_dependency!(self.certificate_chain_synchroniser)
+        get_dependency!(self.certificate_chain_synchronizer)
     }
 
     async fn build_certificate_verifier(&mut self) -> Result<Arc<dyn CertificateVerifier>> {

mithril-aggregator/src/dependency_injection/containers/serve.rs

@@ -58,8 +58,8 @@ pub struct ServeCommandDependenciesContainer {
     /// Chain observer service.
     pub(crate) chain_observer: Arc<dyn ChainObserver>,
 
-    /// Certificate chain synchroniser service
-    pub(crate) certificate_chain_synchroniser: Arc<dyn CertificateChainSynchronizer>,
+    /// Certificate chain synchronizer service
+    pub(crate) certificate_chain_synchronizer: Arc<dyn CertificateChainSynchronizer>,
 
     /// Signer registerer service
     pub signer_registerer: Arc<dyn SignerRegisterer>,

mithril-aggregator/src/runtime/runner.rs

@@ -72,7 +72,7 @@ pub trait AggregatorRunnerTrait: Sync + Send {
     /// Synchronize the follower aggregator signer registration.
     async fn synchronize_follower_aggregator_signer_registration(&self) -> StdResult<()>;
 
-    /// Synchronise the follower aggregator certificate chain
+    /// Synchronize the follower aggregator certificate chain
     async fn synchronize_follower_aggregator_certificate_chain(
         &self,
         force_sync: bool,
@@ -522,7 +522,7 @@ impl AggregatorRunnerTrait for AggregatorRunner {
             ">> synchronize_follower_aggregator_certificate_chain(force_sync:{force_sync})"
         );
         self.dependencies
-            .certificate_chain_synchroniser
+            .certificate_chain_synchronizer
             .synchronize_certificate_chain(force_sync)
             .await
     }

mithril-aggregator/src/services/aggregator_client.rs

@@ -293,7 +293,7 @@ impl AggregatorHTTPClient {
         }
     }
 
-    async fn certificates_details(
+    async fn certificate_details(
         &self,
         certificate_hash: &str,
     ) -> Result<Option<CertificateMessage>, AggregatorClientError> {
@@ -323,7 +323,7 @@ impl AggregatorHTTPClient {
     async fn latest_genesis_certificate(
         &self,
     ) -> Result<Option<CertificateMessage>, AggregatorClientError> {
-        self.certificates_details("genesis").await
+        self.certificate_details("genesis").await
     }
 }
 
@@ -342,7 +342,7 @@ impl CertificateRetriever for AggregatorHTTPClient {
         certificate_hash: &str,
     ) -> Result<Certificate, CertificateRetrieverError> {
         let message = self
-            .certificates_details(certificate_hash)
+            .certificate_details(certificate_hash)
             .await
             .with_context(|| {
                 format!("Failed to retrieve certificate with hash: '{certificate_hash}'")
@@ -365,7 +365,7 @@ impl RemoteCertificateRetriever for AggregatorHTTPClient {
             None => Ok(None),
             Some(latest_certificate_list_item) => {
                 let latest_certificate_message =
-                    self.certificates_details(&latest_certificate_list_item.hash).await?;
+                    self.certificate_details(&latest_certificate_list_item.hash).await?;
                 latest_certificate_message.map(TryInto::try_into).transpose()
             }
         }
@@ -586,7 +586,7 @@ mod tests {
             then.status(200).body(json!(expected_message).to_string());
         });
 
-        let fetched_message = client.certificates_details(&expected_message.hash).await.unwrap();
+        let fetched_message = client.certificate_details(&expected_message.hash).await.unwrap();
 
         assert_eq!(Some(expected_message), fetched_message);
     }
@@ -612,7 +612,7 @@ mod tests {
             then.status(500).body("an error occurred");
         });
 
-        match client.certificates_details("whatever").await.unwrap_err() {
+        match client.certificate_details("whatever").await.unwrap_err() {
             AggregatorClientError::RemoteServerTechnical(_) => (),
             e => panic!("Expected Aggregator::RemoteServerTechnical error, got '{e:?}'."),
         };
@@ -628,7 +628,7 @@ mod tests {
         });
 
         let error = client
-            .certificates_details("whatever")
+            .certificate_details("whatever")
             .await
             .expect_err("retrieve_epoch_settings should fail");
 

…tificate_chain_synchroniser/interface.rs …tificate_chain_synchronizer/interface.rsmithril-aggregator/src/services/certificate_chain_synchroniser/interface.rs renamed to mithril-aggregator/src/services/certificate_chain_synchronizer/interface.rs mithril-aggregator/src/services/certificate_chain_synchroniser/interface.rs renamed to mithril-aggregator/src/services/certificate_chain_synchronizer/interface.rs

@@ -1,7 +1,7 @@
 mod interface;
 mod noop;
-mod synchroniser_service;
+mod synchronizer_service;
 
 pub use interface::*;
 pub use noop::*;
-pub use synchroniser_service::*;
+pub use synchronizer_service::*;

…es/certificate_chain_synchroniser/mod.rs …es/certificate_chain_synchronizer/mod.rsmithril-aggregator/src/services/certificate_chain_synchroniser/mod.rs renamed to mithril-aggregator/src/services/certificate_chain_synchronizer/mod.rs mithril-aggregator/src/services/certificate_chain_synchroniser/mod.rs renamed to mithril-aggregator/src/services/certificate_chain_synchronizer/mod.rs

@@ -3,10 +3,10 @@ use mithril_common::StdResult;
 use crate::services::CertificateChainSynchronizer;
 
 /// A noop [CertificateChainSynchronizer] for leader aggregators
-pub struct MithrilCertificateChainSynchroniserNoop;
+pub struct MithrilCertificateChainSynchronizerNoop;
 
 #[async_trait::async_trait]
-impl CertificateChainSynchronizer for MithrilCertificateChainSynchroniserNoop {
+impl CertificateChainSynchronizer for MithrilCertificateChainSynchronizerNoop {
     async fn synchronize_certificate_chain(&self, _force: bool) -> StdResult<()> {
         Ok(())
     }