Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset and Collectibles sorting #107

Closed
Bolado opened this issue Nov 23, 2021 · 4 comments
Closed

Asset and Collectibles sorting #107

Bolado opened this issue Nov 23, 2021 · 4 comments

Comments

@Bolado
Copy link

Bolado commented Nov 23, 2021

Read on twitter that if a token has "721" json key is considered a collectible, but even the ones who doesn't have, is being placed on collectibles tab.

Cardax Token Metadata (has a json structure on metadata):
Screen Shot 2021-11-23 at 19 20 53

Hosky (has a json structure but no "721" key:
Screen Shot 2021-11-23 at 19 22 53

Judging by the pattern, any FT that has a json structure seems to be being placed on collectibles tab, I got the metadata with the pool.pm lookup, may be wrong.

@alessandrokonrad
Copy link
Contributor

Hosky clearly has the 721 label. Check it on cardanoscan:
https://cardanoscan.io/transaction/1e0612fbd127baddfcd555706de96b46c4d4363ac78c73ab4dee6e6a7bf61fe9?tab=metadata

I'm not sure about the other asset, do you have the asset ID? But I'm pretty sure it has it as well. pool.pm may leave out top level keys.

@Bolado
Copy link
Author

Bolado commented Nov 24, 2021

True that, I got bamboozled, checking the asset id of CARDAX ( asset1s433jdc6gdjryekuyzr0faaw7nyr5dq50f2k9k ) I can see the complete metadata.

Is there a CIP for normal tokens ? I see that the 25 includes 721 label

@alessandrokonrad
Copy link
Contributor

cardano-foundation/CIPs#137
There is this open CIP for normal tokens.

@Bolado
Copy link
Author

Bolado commented Nov 24, 2021

cardano-foundation/CIPs#137 There is this open CIP for normal tokens.

Awesome, thanks Alessandro for clearing things up, closing this now.

@Bolado Bolado closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants