Optimise translating the Byron UTxO to the Shelley UTxO #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UPDATE: merged |
mrBliss
force-pushed
the
mrBliss/optimise-utxo-translation
branch
from
0e68788
to
1fd28cc
Compare
edsko
approved these changes
Jul 24, 2020
mrBliss
commented
Jul 24, 2020
ouroboros-consensus-cardano/src/Ouroboros/Consensus/Cardano/CanHardFork.hs
Outdated
Show resolved
Hide resolved
Instead of going from compact Byron Tx -> normal Byron Tx -> normal Shelley Tx -> compact Shelley Tx, go from compact Byron Tx -> compact Shelley Tx. The crux is to avoid deserialising and reserialising the address in the `TxOut`. I measured the time it took to translate the Byron ledger to the Shelley ledger when syncing mainnet_candidate2: Before: 3.7s After: 1.2s
mrBliss
force-pushed
the
mrBliss/optimise-utxo-translation
branch
from
1fd28cc
to
fa13c2d
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of going from compact Byron Tx -> normal Byron Tx -> normal Shelley Tx
-> compact Shelley Tx, go from compact Byron Tx -> compact Shelley Tx.
The crux is to avoid deserialising and reserialising the address in the
TxOut.I measured the time it took to translate the Byron ledger to the Shelley ledger
when syncing mainnet_candidate2:
Before: 3.7s
After: 1.2s