db-analyser: clean up #2667
Merged
db-analyser: clean up #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classic boolean blindness: in one place the `Bool` meant "testnet" and in another "mainnet". Fix it by using `RequiresNetworkMagic` instead of `Bool`.
* Pass the initial ledger to the analyses. This opens the door for analyses that do block and/or header validation. * Replace `IORef`s by threading some state around. * Parameterise `processAll` over `BlockComponent`. Now, for example, `showHeaderSize` no longer needs to decode the blocks, it just receives the slot number and the header size from the indices. * Introduce `AnalysisEnv`. * Drop unused dependency on `cardano-slotting`.
edsko
approved these changes
Oct 7, 2020
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mainnet vs. testnet bug. Classic boolean blindness: in one place the
Boolmeant "testnet" and in another "mainnet". Fix it by usingRequiresNetworkMagicinstead ofBool.Pass the initial ledger to the analyses. This opens the door for analyses that
do block and/or header validation.
Replace
IORefs by threading some state around.Parameterise
processAlloverBlockComponent. Now, for example,showHeaderSizeno longer needs to decode the blocks, it just receives the slotnumber and the header size from the indices.
Introduce
AnalysisEnv.Drop unused dependency on
cardano-slotting.