Handle exiting threads in diffusion layer #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
force-pushed
the
karknu/diffusion_fail
branch
from
8de93a9
to
fe8f818
Compare
|
Fixes #2684 . |
coot
reviewed
Oct 21, 2020
| @@ -319,9 +327,10 @@ runDataDiffusion tracers | |||
| sd | |||
| (daLocalResponderApplication applications) | |||
| localErrorPolicy | |||
| return () | |||
There was a problem hiding this comment.
Do we need this return? There's void applied to previous monadic action.
There was a problem hiding this comment.
No, the return isn't needed. Will remove it.
coot
reviewed
Oct 21, 2020
| @@ -350,11 +359,12 @@ runDataDiffusion tracers | |||
| sd | |||
| (daResponderApplication applications) | |||
| remoteErrorPolicy | |||
| return () | |||
coot
reviewed
Oct 21, 2020
| @@ -369,13 +379,13 @@ runDataDiffusion tracers | |||
| , spErrorPolicies = remoteErrorPolicy | |||
| , spSubscriptionTarget = daIpProducers | |||
| } | |||
| (daInitiatorApplication applications) | |||
| (daInitiatorApplication applications) >> return () | |||
There was a problem hiding this comment.
It would be cleaner to write:
void $ NodeToNode.ipSubscriptionWorker ...
coot
reviewed
Oct 21, 2020
| @@ -391,7 +401,7 @@ runDataDiffusion tracers | |||
| , spErrorPolicies = remoteErrorPolicy | |||
| , spSubscriptionTarget = dnsProducer | |||
| } | |||
| (daInitiatorApplication applications) | |||
| (daInitiatorApplication applications) >> return () | |||
If a thread spawned by diffusion exits for any reason we kill all other threads and return. This is done to ensure that the node isn't left running in a semi-functional state, for example with the client side working but the server has exited due to a configuration error.
karknu
force-pushed
the
karknu/diffusion_fail
branch
from
fe8f818
to
049c989
Compare
|
This should fix #2519 too. |
|
bors r+ |
|
Build succeeded: |
coot
pushed a commit
that referenced
this pull request
May 16, 2022
2696: Handle exiting threads in diffusion layer r=karknu a=karknu If a thread spawned by diffusion exits for any reason we kill all other threads and return. This is done to ensure that the node isn't left running in a semi-functional state, for example with the client side working but the server has exited due to a configuration error. Example output: `cardano-node: Network.Socket.bind: unsupported operation (Can't assign requested address)⏎` Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a thread spawned by diffusion exits for any reason we kill
all other threads and return. This is done to ensure that the node isn't
left running in a semi-functional state, for example with the client
side working but the server has exited due to a configuration error.
Example output:
cardano-node: Network.Socket.bind: unsupported operation (Can't assign requested address)⏎