Public Root Peers target Diffusion tests #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
changed the title
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
c835f4e to
1b25cae
Compare
bolt12
force-pushed
the
bolt12/diffusion-test-dns-recoverability
branch
from
974d516 to
29dde73
Compare
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
1b25cae to
f8738cc
Compare
bolt12
force-pushed
the
bolt12/diffusion-test-dns-recoverability
branch
from
29dde73 to
ee90827
Compare
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
f8738cc to
9bbb400
Compare
bolt12
force-pushed
the
bolt12/diffusion-test-dns-recoverability
branch
from
ee90827 to
ef53cfe
Compare
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
9bbb400 to
8a04d7d
Compare
bolt12
force-pushed
the
bolt12/diffusion-test-dns-recoverability
branch
from
ef53cfe to
eae62b2
Compare
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
8a04d7d to
4646e34
Compare
bolt12
changed the base branch from
bolt12/diffusion-test-dns-recoverability
to
master
coot
reviewed
May 17, 2022
| ) | ||
| <$> events | ||
| where | ||
| verify_target_established_public :: Events DiffusionTestTrace -> Property |
There was a problem hiding this comment.
Could this be exported by the Test.Ouroboros.Network.Governor module. The same for the other such functions.
There was a problem hiding this comment.
Not quite because although the code looks pretty much the same we are using different ways of obtaining the trace!
There was a problem hiding this comment.
I'd extract the core function which does the validation, and export it. This will allows us to use it in the two different contexts. But this can be done in a separate PR if you prefer.
bolt12
changed the base branch from
master
to
bolt12/diffusion-test-dns-recoverability
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
4646e34 to
4ff8cd4
Compare
bolt12
force-pushed
the
bolt12/diffusion-test-dns-recoverability
branch
from
8660680 to
f8fd974
Compare
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
4ff8cd4 to
955b6ed
Compare
Refactor RootPeersDNS tests to use this change instead of a script of domain maps. Updates JoinNetwork command with possible IP change. If a node restarts with a new IP there's a new thread to update the Domain maps accordingly after some delay. Removed self from DNSMap in DiffusionScript gen Added tracing for DNSMap updating
bolt12
force-pushed
the
bolt12/diffusion-test-dns-recoverability
branch
from
f8fd974 to
c09ee1a
Compare
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
955b6ed to
0d749d7
Compare
bolt12
force-pushed
the
bolt12/diffusion-public
branch
from
0d749d7 to
14fc7a4
Compare
bolt12
changed the base branch from
bolt12/diffusion-test-dns-recoverability
to
master
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.