Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug about 'contrast_prob_diff' #188

Closed
Betswish opened this issue May 26, 2023 · 1 comment · Fixed by #228
Closed

Bug about 'contrast_prob_diff' #188

Betswish opened this issue May 26, 2023 · 1 comment · Fixed by #228
Labels
bug Something isn't working

Comments

@Betswish
Copy link

Betswish commented May 26, 2023

🐛 Bug Report

Hi Inseq team, thanks again for your contribution.
I just noticed a bug when using 'contrast_prob_diff' - output attributions seem to be reversed.
It outputs the attribution of false_answer but not true_answer.

🔬 How To Reproduce

What I did is:

  1. use contrast_prob_diff, and the output attribute for 'morning' and 'evening' is:
    image
    image

  2. use probability (where the variable target_false is useless), and the output attribute for 'morning' and 'evening' is:
    image
    image

The code for the attribute part is: (top: contrast_prob_diff; bottom: probability)
image

@Betswish Betswish added the bug Something isn't working label May 26, 2023
@gsarti gsarti added the to be investigated Requires further inspection before sorting label Jul 28, 2023
@gsarti gsarti linked a pull request Oct 30, 2023 that will close this issue
@gsarti gsarti removed the to be investigated Requires further inspection before sorting label Oct 30, 2023
@gsarti
Copy link
Member

gsarti commented Oct 30, 2023

@Betswish The behavior should be fixed now, please let me know if you face any issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants