Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change new_teal_data arguments #169

Closed
gogonzo opened this issue Sep 29, 2023 · 1 comment
Closed

change new_teal_data arguments #169

gogonzo opened this issue Sep 29, 2023 · 1 comment
Assignees
Labels

Comments

@gogonzo
Copy link
Contributor

gogonzo commented Sep 29, 2023

Acceptance criteria:
Constructor method should have variants for a signature data = "list" and data = "environment".

Constructor should work with following call:

new_teal_data(
  data = list(iris2 = iris2),
  code = quote(iris2 <- iris) 
)

new_teal_data(
  data = as.environment(list(iris2 = iris2)),
  code = quote(iris2 <- iris) 
)
@gogonzo gogonzo changed the title match new_qenv arguments with other classes match new_teal_data arguments with other classes Sep 29, 2023
@donyunardi donyunardi changed the title match new_teal_data arguments with other classes change new_teal_data arguments Oct 19, 2023
@gogonzo gogonzo self-assigned this Oct 23, 2023
@gogonzo gogonzo added the core label Oct 23, 2023
@gogonzo
Copy link
Contributor Author

gogonzo commented Oct 23, 2023

Closing this PR. new_teal_data will be a private constructor. We will expose teal_data/cdisc_data only.

@gogonzo gogonzo closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant