-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducible metadata attribute #76
Comments
@kumamiao @nikolas-burkoff What do you think? Currently metadata is put as a slot in TealDataset and FilteredDataset. Maybe it would be better if we keep it in raw data? |
I'm happy with this, we'll also need to make changes in internal connector packages of course |
Sounds good, no strong preferences from me as long as app developers can 1) grab the metadata within a module 2) use the front page module to check the metadata |
sounds like plan - metadata could be obtained in the module by: # in case of datasets <FilteredData>
attr(datasets$get_data(<dataname>), "metadata")
# in case of data <list of reactive data>
attr(data[[<dataname>]](), "metadata") |
implemented with new teal_data |
Feature description
If TealDataset's metadata was an attribute of the data - then:
attr(<dataset>, "metadata") <- <metadata call>
.attr(<raw data>, "metadata")
Code of Conduct
Contribution Guidelines
Security Policy
The text was updated successfully, but these errors were encountered: