-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS file isn't written to /lib #11
Comments
The CSS which gets written to Do you know what common practices for shipping Sass (and compiled CSS?) are for components? Personally I've only shipped components which used CSS, and I just stuck that in a There's also a |
Thanks for the quick reply!
Ironically, I came across this issue because I was curious how nwb would handle it. I'm currently searching for working examples. That said, I was expecting it to:
I'm confused. What is the intended use case for this? CSS is handled great for the umd build, so it appears the gap is the /lib build behavior. Agreed? |
I am also experiencing this issue. I would be happy to have the css generated to a /css directory. Note, I would appreciate this working for both the At present this is causing an issue for my team where users of our component library need to consume our sass files to make the components render correctly. I'd prefer that the could just include a css file and call it a day without updating their webpack config. |
Has there been any more thought to this story? Our team has several versions of the same component library, each submodule'ing in a shared sass lib. I'd rather not make the consumers of my nwb react library compile the sass themselves. Several people have suggested using the same approach as Create-React-App where you author in sass and import the resulting css into your component's js. Would that be the recommendation for my use case? |
Just came across this happening in a new component I'm trying to publish. Has there been any traction on this as of yet? |
I created a PR documenting how this should be done. It's basically the same thing you'd do for CRA. |
Currently an imported Sass file isn't written to /lib. It's only written to /umd. Is this a known limitation, or a bug?
The text was updated successfully, but these errors were encountered: