Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Evaluate updating the config server UI dependecies to the latest versions #1460

Open
salim-1997 opened this issue Jun 1, 2022 · 5 comments
Assignees
Labels
area/config-ui dependencies Pull requests that update a dependency file

Comments

@salim-1997
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently the config server UI is using dependencies with lower versions than the latest. Although these dependencies now are running without complications, a lot more could be reached with newer versions (more features). Also these outdated versions could potentially cause security problems in the future.
However updating these dependencies to the latest could crash certain parts in the App due to potential compatibility issues.

Describe the solution you'd like
A good solution for that would be evaluating the possibilities and seeing if there is any crucial dependency version that cannot be changed and updating the dependencies that can be updating without complications.

Describe alternatives you've considered
A better alternative would be updating all the dependencies without exception and adapting the app to be running on the latest versions.

@salim-1997 salim-1997 added area/config-ui dependencies Pull requests that update a dependency file idea A rough idea for a feature or extension and removed idea A rough idea for a feature or extension labels Jun 1, 2022
@salim-1997
Copy link
Member Author

salim-1997 commented Jun 2, 2022

I realized that it might not be possible to update the entirety of the dependencies since some of the new dependency versions require premium features, like the theme support of Primereact starting from version 7.

@heiko-holz
Copy link
Contributor

Hey @salim-1997 I’m using ZenHub in GitHub, click this link to join my workspace and see other features available in GitHub or download the ZenHub extension and sign up with your GitHub account.
Posted using ZenHub

@salim-1997
Copy link
Member Author

salim-1997 commented Jul 19, 2022

After the first evaluation, some dependencies have been updated. All the patches and the minor version updates have been made. But there are still some major version updates that need a specific analysis.

  • These are the dependencies that were first out-of-date:
    image
  • And these are the dependencies that would still require specific analysis to be updated successfully:
    image

As a next step, i will document each of these dependencies and see what is needed to change for them to function correctly.

@salim-1997
Copy link
Member Author

Current major version updates:

  • primeflex ✔️
  • primeicons ✔️
  • jwt-decode ✔️
  • eslint dependencies ✔️
  • react-redux ✔️
  • react-synstax-highlighter ✔️
  • react-timeago ✔️
  • react-redux ✔️
  • react ❌
  • react-dom ❌
  • file-loader ❌
  • url-loader ❌
  • primereact ❌
  • js-yaml ❌
  • dateformat ❌
  • next ❌

@salim-1997
Copy link
Member Author

  • js-yaml updated ✔️: function yaml.safeLoad() is changed in version 4 with yaml.load(). Safe loading is now by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config-ui dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants