Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Keep query parameters #4

Open
joehi opened this issue Apr 23, 2019 · 6 comments
Open

Feature: Keep query parameters #4

joehi opened this issue Apr 23, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@joehi
Copy link
Contributor

joehi commented Apr 23, 2019

It would be nice to have in option to keep certain query parameters.

I have something in mind like at the package changelanguage where I have a field Keep query parameters.

The description could be: "Enter a comma separated list of query parameters that should be kept when linking."

An usecase would be to control with a query parameter whether to show or not show additional information like a map on the reader-page. I would like to reference for such a scenario to a discussion in the Contao-forum.

@fritzmg
Copy link
Contributor

fritzmg commented Apr 23, 2019

Hm, well you could also add the necessary parameters in your own template.

@joehi
Copy link
Contributor Author

joehi commented Apr 23, 2019

Thank you for the hint. I will try it that way.

@joehi
Copy link
Contributor Author

joehi commented Apr 23, 2019

I created my own mod_sibling_navigation__modified template but I cannot select it from the "Custom module template" dialog. The selection stays empty. How can I select my own template?

@joehi joehi closed this as completed Apr 23, 2019
@joehi joehi reopened this Apr 23, 2019
@fritzmg
Copy link
Contributor

fritzmg commented Apr 23, 2019

Hm... try with mod_sibling_navigation_events_modified.html5 for example.

@joehi
Copy link
Contributor Author

joehi commented Apr 23, 2019

Thank you. Now I could select it. I did not expect that I would have to add something to the official name to make it show up in the dialog.

@fritzmg
Copy link
Contributor

fritzmg commented Apr 23, 2019

Yeah it's a special case. It's two different modules - but only one template. To select a custom module template in Contao 4.4+, you need to name the template according to the module name.

@fritzmg fritzmg added the bug Something isn't working label Aug 26, 2019
@fritzmg fritzmg self-assigned this Aug 26, 2019
@fritzmg fritzmg added enhancement New feature or request and removed bug Something isn't working labels Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants