Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed BUG #100

Closed
wants to merge 3 commits into from
Closed

Fixed BUG #100

wants to merge 3 commits into from

Conversation

Aaliya1708
Copy link

Please fill in this pull request template before submitting

1. This pull request resolves #98

2. Description

Modifying the STDIN can help us check the functions for the dummy inputs
this can also help us automate the solution checking in the workflow itself

3. Fill in checklist by marking [x]

  • I've read the CONTRIBUTING.md
  • I was assigned to this issue
  • My code is formatted using required linting
  • I've run my code locally and checked it works

@funbeedev
Copy link
Member

@Aaliya1708 Thanks for the PR!
There was a small linting check error but I've fixed now.

I see you added a way of passing an input but ideally this change should not affect the tutorial. For example, if the user wants to enter in their own input they need to remove the StringIO part and checking the factorial of any number other than 10 results in an assert error. This might be tricky to understand for anyone new to Python and who just wants to learn about recursive functions.

For these reasons I can't merge the code as is but it's opened up some possible ideas to how we can overcome this in future so still happy to accept for hacktoberfest!

Btw if you have any other ideas for workarounds feel free to make changes to the PR!
Maybe there's also something that can be done in the GitHub action to check the python file while also passing in dummy values to any programs using input?

@funbeedev funbeedev added change required before merge! Make the change requested in the PR comment hacktoberfest-accepted accept for hacktoberfest labels Oct 27, 2021
@funbeedev funbeedev added stale no activity and removed change required before merge! Make the change requested in the PR comment hacktoberfest-accepted accept for hacktoberfest labels Oct 4, 2022
@funbeedev funbeedev closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale no activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub action 'execute-modified-python-file.yml' fails if program uses 'input()'
2 participants
@Aaliya1708 @funbeedev