Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context: thread-local cache for previous context stickiness #158

Merged
merged 2 commits into from
Jul 5, 2017
Merged

Context: thread-local cache for previous context stickiness #158

merged 2 commits into from
Jul 5, 2017

Conversation

jeremy
Copy link
Contributor

@jeremy jeremy commented Jun 29, 2017 •
edited
Loading

  • Fix that previous-stickiness check was cached for all configs
  • Check Ruby Thread capabilities once rather than at runtime
  • Choose thread-local get/set strategy once when we define the fetch/set methods rather than on every method call.

References ae2be27 and #156

@bleonard
Copy link
Contributor

bleonard commented Jul 5, 2017

@jeremy I just merged in a fix from @vt-gpatrick that lowered the number of checks to the Rails.cache that conflicts with this one.
Could you port this over to master?

@jeremy jeremy changed the title Context: check Ruby Thread capabilities once rather than at runtime Context: thread-local cache for previous context stickiness Jul 5, 2017
@jeremy
Copy link
Contributor Author

jeremy commented Jul 5, 2017

Rebased on master and updated #156 to support multiple configs.

@jeremy
Context: thread-local cache for previous context stickiness
546670b 
* Fix that previous-stickiness check was cached for all configs
* Check Ruby Thread capabilities once rather than at runtime
* Choose thread-local get/set strategy once when we define the fetch/set
  methods rather than on every method call.

References ae2be27
References #156
@jeremy
Tests: work around flaky schema setup failures on Ruby 2.1 + AR 3.0
0729cd1
@bleonard bleonard mentioned this pull request Jul 5, 2017
Merged
@bleonard bleonard merged commit ccf8199 into instacart:master Jul 5, 2017
@jeremy jeremy deleted the thread-local-runtime-duck-type branch July 6, 2017 00:28
@bleonard bleonard mentioned this pull request Jul 6, 2017
Closed
@rosa rosa mentioned this pull request Feb 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremy @bleonard