-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated IGListCollectionViewLayout to rely on layoutAttributesClass #1135
Conversation
…instead of just allocating a vanilla UICollectionViewLayoutAttributes
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
@SirensOfTitan has updated the pull request. View: changes |
@SirensOfTitan has updated the pull request. View: changes |
Generated by 🚫 Danger |
Fantastic, thank you! @SirensOfTitan you'll need to follow the steps on the bot post above to update your CLA status before we can merge. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@SirensOfTitan has updated the pull request. View: changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…instead of just allocating a vanilla UICollectionViewLayoutAttributes. I'm happy to add tests here, but don't really have much of an opinion either way on whether this should have an explicit test case or not.
Changes in this pull request
Issue fixed: #1134
Checklist
CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.