Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated IGListCollectionViewLayout to rely on layoutAttributesClass #1135

Closed
wants to merge 4 commits into from
Closed

Conversation

SirensOfTitan
Copy link
Contributor

…instead of just allocating a vanilla UICollectionViewLayoutAttributes. I'm happy to add tests here, but don't really have much of an opinion either way on whether this should have an explicit test case or not.

Changes in this pull request

Issue fixed: #1134

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

…instead of just allocating a vanilla UICollectionViewLayoutAttributes
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

@facebook-github-bot
Copy link
Contributor

@SirensOfTitan has updated the pull request. View: changes

@facebook-github-bot
Copy link
Contributor

@SirensOfTitan has updated the pull request. View: changes

@iglistkit-bot
Copy link

iglistkit-bot commented Mar 20, 2018

1 Warning
⚠️ All pull requests should have a milestone attached, unless marked #trivial.

Generated by 🚫 Danger

@rnystrom
Copy link
Contributor

rnystrom commented Mar 22, 2018

Fantastic, thank you! @SirensOfTitan you'll need to follow the steps on the bot post above to update your CLA status before we can merge.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@SirensOfTitan has updated the pull request. View: changes

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListCollectionViewLayout does not allocate UICollectionViewAttributes using layoutAttributesClass
4 participants