Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom error type for Tokenizer::with_vocabulary #2

Open
michael-p opened this issue Nov 24, 2023 · 0 comments
Open

Use custom error type for Tokenizer::with_vocabulary #2

michael-p opened this issue Nov 24, 2023 · 0 comments

Comments

@michael-p
Copy link
Contributor

Currently, the Tokenizer::with_vocabulary constructor returns a std::io::Error error, abusing the io::ErrorKind::Other variant for situations where the vocabulary data format is invalid.

We should probably provide a custom crate-level Error type and use that instead, with one variant for I/O-errors and further variants for invalid data formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant