Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 deprecations #23

Open
Ang3 opened this issue Feb 15, 2022 · 0 comments · May be fixed by #24
Open

PHP 8 deprecations #23

Ang3 opened this issue Feb 15, 2022 · 0 comments · May be fixed by #24

Comments

@Ang3
Copy link

Ang3 commented Feb 15, 2022

Describe the bug

PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (line 366 and 479).

sms-counter-php/SMSCounter.php

Line 366 in a0f017d

$len = strlen($str);

sms-counter-php/SMSCounter.php

Line 479 in a0f017d

if (strlen($replacement) > 1) {

To reproduce

Run the library on PHP8, then try to sanitize a value. You should have some deprecations.

(OPTIONAL) Additional context

  • PHP 8
@soundslocke soundslocke linked a pull request Sep 4, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates and PHP 8.1 compatibility GigSalad/sms-counter-php
1 participant
@Ang3