Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for batching and parallel data generation #167

Closed
bbrowning opened this issue Jul 18, 2024 · 3 comments
Closed

Add support for batching and parallel data generation #167

bbrowning opened this issue Jul 18, 2024 · 3 comments

Comments

@bbrowning
Copy link
Contributor

The changes from aakankshaduggal#6 add support for batching and parallel data generation. This issue is to track getting those changes merged into instructlab/sdg main. Part of this work will be to ensure that's the entirety of the necessary batching and data parallel generation commits contained within the referenced pull request and then rebasing/cherry-picking those changes plus any cleanup work required to merge in.

@bbrowning
Copy link
Contributor Author

This may actually be a duplicate of #135 upon further reading, as I see 135 has refocused on getting these types of changes in. Will investigate further and close this one if so.

@markmc
Copy link
Contributor

markmc commented Jul 18, 2024

Yep, the description for #135 came from aakankshaduggal#8 which was superseded by aakankshaduggal#6

@bbrowning
Copy link
Contributor Author

Ok - closing this as duplicate in favor of continuing to track this in the older #135

@bbrowning bbrowning closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants