rubocop: Rails/Delegate and Lint/CopDirectiveSyntax

Change-Id: Ie43783fe24d9f9eb0f12fa521d3db6308aeebb84
Reviewed-on: https://gerrit.instructure.com/c/analytics/+/370552
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>

Author: ccutrer

lib/analytics/assignment_submission.rb

@@ -40,7 +40,7 @@ def recorded_at
         # if we expect a submission return submitted_at because canvas expects a
         # submission to be submitted.
         submitted_at
-      elsif graded_at.nil? || (@submission.graded? && @submission.score == 0) # rubocop:disable Lint/DuplicateBranch https://github.com/rubocop/rubocop/issues/10153
+      elsif graded_at.nil? || (@submission.graded? && @submission.score == 0) # rubocop:disable Lint/DuplicateBranch -- https://github.com/rubocop/rubocop/issues/10153
         # if graded_at is nil we know that due_at is in the future.  We know it
         # must be in the future because @submission.missing? above would have
         # been true.  With due_at in the future, means it has not been recorded yet.
@@ -100,9 +100,7 @@ def submitted_at
       @submission&.submitted_at
     end
 
-    def non_digital_submission?
-      @assignment.non_digital_submission?
-    end
+    delegate :non_digital_submission?, to: :@assignment
 
     private
 

lib/analytics/rollups/score_buckets.rb

@@ -69,13 +69,9 @@ def index_for(value)
       ((value / @bucket_size) + 0.5).floor
     end
 
-    def max
-      @counter.max
-    end
+    delegate :max, to: :@counter
 
-    def min
-      @counter.min
-    end
+    delegate :min, to: :@counter
 
     def first_quartile
       @counter.quartiles[0]