Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documents should not be labeled empty unless they're actually empty #145

Closed
ian-howell opened this issue Jul 17, 2019 · 0 comments
Closed

Documents should not be labeled empty unless they're actually empty #145

ian-howell opened this issue Jul 17, 2019 · 0 comments

Comments

@ian-howell
Copy link
Contributor

ian-howell commented Jul 17, 2019 •
edited
Loading

Running kubeval against https://raw.githubusercontent.com/instrumenta/kubeval/master/fixtures/multi_invalid.yaml currently gives the following output:

The document fixtures/multi_valid.yaml contains a valid Service
The document fixtures/multi_valid.yaml contains a valid ReplicationController
The document fixtures/multi_valid.yaml contains a valid Service
The document fixtures/multi_valid.yaml contains a valid ReplicationController
The document fixtures/multi_valid.yaml contains a valid Service
The document fixtures/multi_valid.yaml contains a valid ReplicationController
The document fixtures/multi_valid.yaml is empty
The document fixtures/multi_valid.yaml is empty

This output is a bit misleading; kubeval should not report that a non-empty file is empty. Perhaps it makes more sense to state that

The file fixtures/multi_valid.yaml contains an empty YAML document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garethr @ian-howell