-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version on binder does not plot. #70
Comments
I believe this is the same as #69 |
Works OK now? |
I clicked the binder link, ran the notebook, got a plot, but then (yipes) I get this: |
Constant unzooming! Is there an issue for this? |
Do you think it's a holoviews/geoviews issue or an xrviz issue? |
As far as I know, xrviz creates the plot and then leaves it alone. It is plausible that the layout is being recalculated somehow... @philippjfr , your thoughts? |
Yeah something in holoviews. It's probably to do with aspect handling. Is this using recent HoloViews yet? |
The script uses "current" versions (whatever conda gives us from conda-forge on py37) |
@rsignell-usgs , if you still have this open, would be good to post the versions binder ended up using |
|
Okay, so definitely latest, I'll try to reproduce. |
Okay, I see the same thing. Will see if I can get a 1.13.3 release with a fix out very soon. |
The plot works for me now on the binder, thanks! |
@philippjfr I'm so glad you could replicate the zooming out feedback loop issue and it sounds like you see the solution also. Awesome! |
Just wish we had an automated way to catch these kinds of regressions. Unfortunately testing client-server interactions in a browser is hard. |
Currently, the version that is opened with the binder does not make the plot, even if I click the
Plot
button.The text was updated successfully, but these errors were encountered: