r/github_branch_protection: check invalid users #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is PR an attempt to fix #95. As reported in the issue the GitHUB V3 API does not report error when invalid user login are submitted to replace user restrictions of protected branch. It seems that the API ignores the invalid user and update the list only with the valid ones. It also return the updated list as part of the response.
This PR includes a way to check the resulting users list from the response and compare it with the user input in order to report the error properly.
Please let me know what you think. Thank you.